Messages in this thread | | | Date | Tue, 18 Jun 2013 19:30:38 +0200 | From | Peter Zijlstra <> | Subject | Re: [PATCH 2/3] sched: don't call get_group() for covered cpus |
| |
On Tue, Jun 18, 2013 at 08:59:39PM +0530, Viresh Kumar wrote: > On 18 June 2013 20:49, Peter Zijlstra <peterz@infradead.org> wrote: > > Sure. Just send a new patch and I'll substitute. > > This is the new log (patch is attached): > > sched: Fix memory leakage in build_sched_groups() > > In build_sched_groups() we don't need to call get_group() for cpus which are > already covered in previous iterations. Calling get_group() would mark the group > used and eventually leak it since we wouldn't connect it and not find it again > to free it. > > This will happen only in cases where sg->cpumask contained more than one cpu > (For any topology level). This patch would free sg's memory for all cpus leaving > the group leader as the group isn't marked used now. > > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Thanks!
| |