Messages in this thread | | | Date | Tue, 18 Jun 2013 09:53:15 -0600 | From | Stephen Warren <> | Subject | Re: [PATCH v2 2/4] MFD: Palmas: Add SMPS10_BOOST feature |
| |
On 06/18/2013 04:03 AM, J Keerthy wrote: > The SMPS10 regulator is not presesnt in all the variants > of the PALMAS PMIC family. Hence adding a feature to distingush > between them.
> diff --git a/drivers/mfd/palmas.c b/drivers/mfd/palmas.c
> + match = of_match_device(of_match_ptr(of_palmas_match_tbl), &i2c->dev); > + > + if (match) { > + features = (unsigned int *)match->data; > + palmas->features = *features; > + } else { > + return -ENODATA; > + }
I think it's more common to do the error-checking first. That way, the success-case code doesn't need an indent:
match = of_match...(...); if (!match) return -ENODATA;
features = ...; palmas->features = *features;
| |