Messages in this thread | | | Date | Tue, 18 Jun 2013 12:01:20 -0400 | From | Theodore Ts'o <> | Subject | Re: [ext3,ext4] old bug in htree_dirblock_to_tree() |
| |
On Mon, Jun 17, 2013 at 04:23:38PM +0100, Al Viro wrote: > Both ext3 and ext4 htree_dirblock_to_tree() is just filling > the in-core rbtree for use by call_filldir(). All updates of > ->f_pos are done by the latter; bumping it here (on error) is obviously > wrong - we might very well have it nowhere near the block we'd found > an error in. > > Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Applied, thanks. Nice catch!
Jan, I'll carry the fix for ext3 as well in the ext4 tree, unless you'd prefer otherwise.
- Ted
| |