Messages in this thread | | | Date | Tue, 18 Jun 2013 09:51:39 -0600 | From | Stephen Warren <> | Subject | Re: [PATCH v2 1/4] MFD: Palmas: Check if interrupts property exists and then only request irq |
| |
On 06/18/2013 04:01 AM, J Keerthy wrote: > Check if interrupts property exists and then only request irq. > On some boards INT line might not be connected to a valid > irq line on the application processor. Hence keeping a check > before requesting irq.
When there is no interrupts property, surely i2c->irq == 0, which is an invalid IRQ, and hence there's no need to check this before copying the value?
In other words, I think this whole patch could just be:
+ palmas->irq = i2c->irq;
right?
| |