lkml.org 
[lkml]   [2013]   [Jun]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v7 2/9] usb: phy: omap-usb2: use the new generic PHY framework
    Hi,

    On Tue, Jun 18, 2013 at 03:26:23PM +0530, Kishon Vijay Abraham I wrote:
    > >>>On Thu, Jun 13, 2013 at 02:13:52PM +0530, Kishon Vijay Abraham I wrote:
    > >>>>@@ -159,6 +191,12 @@ static int omap_usb2_probe(struct platform_device *pdev)
    > >>>> otg->start_srp = omap_usb_start_srp;
    > >>>> otg->phy = &phy->phy;
    > >>>>
    > >>>>+ pm_runtime_enable(phy->dev);
    > >>>
    > >>>enabling pm_runtime here has the potential to cause a real big problem.
    > >>>How have you tested this patch ?
    > >>
    > >>performed boot and enumeration testing. What issue do you expect here?
    > >
    > >hint: look at drvdata usage around the driver. Where is it initialized ?
    > >Where is it used ?
    >
    > hmm.. since runtime_get calls weren't made very early, I think I dint
    > see any issues. Thanks for pointing this.

    right, no problem. BTW, you don't get to_platform_device() ->
    platform_get_drvdata(). A simple dev_get_drvdata() is sufficient :-)

    --
    balbi
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2013-06-18 12:41    [W:2.752 / U:0.408 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site