lkml.org 
[lkml]   [2013]   [Jun]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] libata: remove dead code from libata-acpi.c
    On 06/18/2013 02:01 AM, Tejun Heo wrote:
    > On Mon, Jun 17, 2013 at 09:50:20AM +0800, Aaron Lu wrote:
    >> On 06/15/2013 11:02 AM, Liu Jiang wrote:
    >>> From: Liu Jiang <liu97@gmail.com>
    >>>
    >>> Commit 30dcf76acc69 "libata: migrate ACPI code over to new bindings"
    >>> removed ACPI dock notification related code, but there's some dead
    >>> code left, so clean up it.
    >>
    >> I never noticed this, but it looks to be the case...
    >>
    >> I'm not sure the dock notification code is removed intentionally or
    >> mistakenly though, if it is a mistake, then instead of removing the left
    >> code here, we probably should add the dock notification code back.
    >>
    >> But I have no test system or any knowledge about how ata dock works, so
    >> I may be wrong :-)
    >
    > Looks like a regression to me. We're probably locking up on some
    > older laptops which connects optical drives with hotpluggable PATA.
    > Matthew, can you please fix it?

    A user just reported a bug for this:
    https://bugzilla.kernel.org/show_bug.cgi?id=59871

    And bisected to commit 30dcf76acc69. I proposed a fix patch there, let's
    see what the user's test result.

    Thanks,
    Aaron


    \
     
     \ /
      Last update: 2013-06-18 12:41    [W:3.277 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site