Messages in this thread | | | Date | Tue, 18 Jun 2013 12:41:35 +0900 | From | Masami Hiramatsu <> | Subject | Re: Re: [PATCH 2/3] tracing/kprobes: Kill probe_enable_lock |
| |
(2013/06/18 0:18), Oleg Nesterov wrote: >> because >> those calls are the reason why I have introduced this lock. > > Please do not hesitate to nack this patch if you think that we should > keep probe_enable_lock for safety even if it is not currently needed. > In this case I'd suggest to move lock/unlock into kprobe_register() > but this is minor.
Oh, I agree with removing probe_enable_lock itself :) I just concerned only about the exceptional case of __init test function, which can mislead someone to use enable/disable_trace_probe at other racy point.
Thank you,
-- Masami HIRAMATSU IT Management Research Dept. Linux Technology Center Hitachi, Ltd., Yokohama Research Laboratory E-mail: masami.hiramatsu.pt@hitachi.com
| |