Messages in this thread | | | Date | Tue, 18 Jun 2013 09:15:05 +0800 | From | "Jiang Liu (Gerry)" <> | Subject | Re: [PATCH] libata: remove dead code from libata-acpi.c |
| |
On 2013/6/18 2:01, Tejun Heo wrote: > On Mon, Jun 17, 2013 at 09:50:20AM +0800, Aaron Lu wrote: >> On 06/15/2013 11:02 AM, Liu Jiang wrote: >>> From: Liu Jiang <liu97@gmail.com> >>> >>> Commit 30dcf76acc69 "libata: migrate ACPI code over to new bindings" >>> removed ACPI dock notification related code, but there's some dead >>> code left, so clean up it. >> >> I never noticed this, but it looks to be the case... >> >> I'm not sure the dock notification code is removed intentionally or >> mistakenly though, if it is a mistake, then instead of removing the left >> code here, we probably should add the dock notification code back. >> >> But I have no test system or any knowledge about how ata dock works, so >> I may be wrong :-) > > Looks like a regression to me. We're probably locking up on some > older laptops which connects optical drives with hotpluggable PATA. > Matthew, can you please fix it? > > Thanks. > Yeah, Aaron is right. We should restore the dock notification handler to support ATA hotplug on some IBM laptops. Regards! Gerry
| |