lkml.org 
[lkml]   [2013]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mm: Remove unlikely from the current_order test
On Tue, 18 Jun 2013, Zhang Yanfei wrote:

> From: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
>
> In __rmqueue_fallback(), current_order loops down from MAX_ORDER - 1
> to the order passed. MAX_ORDER is typically 11 and pageblock_order
> is typically 9 on x86. Integer division truncates, so pageblock_order / 2
> is 4. For the first eight iterations, it's guaranteed that
> current_order >= pageblock_order / 2 if it even gets that far!
>
> So just remove the unlikely(), it's completely bogus.
>
> Suggested-by: David Rientjes <rientjes@google.com>
> Signed-off-by: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>

Acked-by: David Rientjes <rientjes@google.com>


\
 
 \ /
  Last update: 2013-06-18 02:41    [W:0.513 / U:0.280 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site