Messages in this thread | | | Date | Mon, 17 Jun 2013 16:56:17 -0700 (PDT) | From | David Rientjes <> | Subject | Re: [PATCH] mm: Remove unlikely from the current_order test |
| |
On Tue, 18 Jun 2013, Zhang Yanfei wrote:
> From: Zhang Yanfei <zhangyanfei@cn.fujitsu.com> > > In __rmqueue_fallback(), current_order loops down from MAX_ORDER - 1 > to the order passed. MAX_ORDER is typically 11 and pageblock_order > is typically 9 on x86. Integer division truncates, so pageblock_order / 2 > is 4. For the first eight iterations, it's guaranteed that > current_order >= pageblock_order / 2 if it even gets that far! > > So just remove the unlikely(), it's completely bogus. > > Suggested-by: David Rientjes <rientjes@google.com> > Signed-off-by: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
Acked-by: David Rientjes <rientjes@google.com>
| |