Messages in this thread | | | Date | Mon, 17 Jun 2013 16:16:06 -0700 | From | Greg KH <> | Subject | Re: [PATCH 3/8] FMC: add core bus driver |
| |
On Wed, Jun 12, 2013 at 09:13:47AM +0200, Alessandro Rubini wrote: > --- a/drivers/fmc/fmc-core.c > +++ b/drivers/fmc/fmc-core.c > @@ -1,13 +1,285 @@ > -/* Temporary placeholder so the empty code can build */ > +/* > + * Copyright (C) 2012 CERN (www.cern.ch) > + * Author: Alessandro Rubini <rubini@gnudd.com> > + * > + * Released according to the GNU GPL, version 2 or any later version.
I have to ask, do you really mean "or any later version"?
> +int fmc_driver_register(struct fmc_driver *drv) > +{ > + if (fmc_check_version(drv->version, drv->driver.name)) > + return -EINVAL; > + drv->driver.bus = &fmc_bus_type; > + return driver_register(&drv->driver); > +} > +EXPORT_SYMBOL(fmc_driver_register); > + > +void fmc_driver_unregister(struct fmc_driver *drv) > +{ > + driver_unregister(&drv->driver); > +} > +EXPORT_SYMBOL(fmc_driver_unregister);
Any specific reason these aren't EXPORT_SYMBOL_GPL()?
Again, just have to ask.
thanks,
greg k-h
| |