Messages in this thread | | | Date | Mon, 17 Jun 2013 16:15:02 -0700 | From | Greg KH <> | Subject | Re: [PATCH 3/8] FMC: add core bus driver |
| |
On Wed, Jun 12, 2013 at 09:13:47AM +0200, Alessandro Rubini wrote: > +static void fmc_release(struct device *dev) > +{ > + struct fmc_device *fmc = container_of(dev, struct fmc_device, dev); > + > + kfree(fmc); > +}
I read so many people who write new bus / device code that get this wrong, that I'm so overjoyed when it is written correctly, that I'm almost willing to just blindly accept this whole patchset.
Almost :)
Seriously, very nice job on the whole driver model integration for this code.
thanks,
greg k-h
| |