lkml.org 
[lkml]   [2013]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/8] FMC: add core bus driver
On Wed, Jun 12, 2013 at 09:13:47AM +0200, Alessandro Rubini wrote:
> +static void fmc_release(struct device *dev)
> +{
> + struct fmc_device *fmc = container_of(dev, struct fmc_device, dev);
> +
> + kfree(fmc);
> +}

I read so many people who write new bus / device code that get this
wrong, that I'm so overjoyed when it is written correctly, that I'm
almost willing to just blindly accept this whole patchset.

Almost :)

Seriously, very nice job on the whole driver model integration for this
code.

thanks,

greg k-h


\
 
 \ /
  Last update: 2013-06-18 02:01    [W:0.130 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site