lkml.org 
[lkml]   [2013]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 4/4 v2] silicom: checkpatch: errors caused by macros
From
Date
On Mon, 2013-06-17 at 21:20 +0200, Lorenz Haspel wrote:
> fixed checkpatch error:
> added parenthesis around complex macro.
>
> Macro with return was only used once in the code,
> so I expandet it in-place.
[]
> diff --git a/drivers/staging/silicom/bpctl_mod.c b/drivers/staging/silicom/bpctl_mod.c
[]
> -#define lock_bpctl() \
> -if (down_interruptible(&bpctl_sema)) { \
> - return -ERESTARTSYS; \
> -} \
> -
> #define unlock_bpctl() \
> up(&bpctl_sema);

Symmetry please.

Most likely, this unlock_bpctl macro is only used once too.
I suggest removing it as well.




\
 
 \ /
  Last update: 2013-06-17 22:01    [W:0.066 / U:0.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site