lkml.org 
[lkml]   [2013]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] ARM: mm: cpu_fa526_do_idle: remove WFI
Date
On Monday 17 June 2013 16:58:14 Jonas Jensen wrote:
> On 17 June 2013 16:30, Russell King - ARM Linux <linux@arm.linux.org.uk> wrote:
> > It replaces the WFI and return with a pure nop, so we will fall through
> > to cpu_fa526_dcache_clean_area(). Do we really want to clean a random
> > D cache entry depending on what r0 happened to hold at this point? I
> > think not...
>
> I'm sorry for making the assumption that I know even the most basic
> ARM assembler...
>
> This is not the sort of thing I deal with (and probably shouldn't) on
> a daily basis.
>
> Can I make a guess, remove only mcr and replace it with nop?

No need for the nop, just remove the mcr instruction.

Arnd


\
 
 \ /
  Last update: 2013-06-17 17:41    [W:1.860 / U:0.560 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site