lkml.org 
[lkml]   [2013]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] mn10300: Fix include dependency in irqflags.h
On 06/17/2013 03:12 AM, Geert Uytterhoeven wrote:
> On Mon, Jun 17, 2013 at 9:07 AM, Geert Uytterhoeven
> <geert@linux-m68k.org> wrote:
>> On Sun, Jun 16, 2013 at 10:06 PM, <ddaney.cavm@gmail.com> wrote:
>>> From: David Daney <david.daney@cavium.com>
>>>
>>> We need to pick up the definition of raw_smp_processor_id() from
>>> asm/smp.h. For the !SMP case, we need to supply a definition of
>>> raw_smp_processor_id().
>> Thanks, this fixes the build!
>>
>>> Signed-off-by: David Daney <david.daney@cavium.com>
>> Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Sorry, I acked to soon. While SMP=n is fine (asb2303_defconfig),
> there's a new regression with asb2364_defconfig, which has SMP=y:
>
> CC arch/mn10300/kernel/asm-offsets.s
> In file included from
> /scratch/geert/linux/linux/arch/mn10300/include/asm/irqflags.h:18:0,
> from /scratch/geert/linux/linux/include/linux/irqflags.h:15,
> from /scratch/geert/linux/linux/include/linux/spinlock.h:53,
> from /scratch/geert/linux/linux/include/linux/seqlock.h:29,
> from /scratch/geert/linux/linux/include/linux/time.h:5,
> from /scratch/geert/linux/linux/include/uapi/linux/timex.h:56,
> from /scratch/geert/linux/linux/include/linux/timex.h:56,
> from /scratch/geert/linux/linux/include/linux/sched.h:17,
> from
> /scratch/geert/linux/linux/arch/mn10300/kernel/asm-offsets.c:7:
> /scratch/geert/linux/linux/arch/mn10300/include/asm/smp.h:88:34:
> error: unknown type name 'smp_call_func_t'
> make[4]: *** [arch/mn10300/kernel/asm-offsets.s] Error 1

I am truly in Include Hell. I will attempt a better fix...

David Daney



> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds



\
 
 \ /
  Last update: 2013-06-17 17:41    [W:0.073 / U:0.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site