| Date | Thu, 13 Jun 2013 11:25:26 +0200 | From | Sebastian Andrzej Siewior <> | Subject | Re: am335x: TSC & ADC reworking including DT pieces, take 5 |
| |
On 06/13/2013 11:07 AM, Samuel Ortiz wrote: > Hi Sebastian,
Hi Samuel,
> Pulled and pushed back to mfd-next, thanks.
Thank you.
> I fixed a couple of unused variable warnings on top of it.
I saw your patch at git.k.o and I am asking you not to taking it :) The code is:
of_property_for_each_u32(node, "ti,adc-channels", prop, cur, val) { adc_channels++; if (val > 7) { dev_err(&pdev->dev, " PIN numbers are 0..7 (not %d)\n", val); return -EINVAL; } }
and without CONFIG_OF of_property_for_each_u32() becomes most likely empty. That is why I haven't seen it. So either the macro should be changed to tell the compiler that the variables are used (so the warning does not show up) or let the driver depend on CONFIG_OF. I will look at the former and can prepare a patch for the latter if you want.
> > Cheers, > Samuel. >
Sebastian
|