Messages in this thread | | | Date | Wed, 12 Jun 2013 19:41:15 -0700 | Subject | Re: [PATCH 04/11] cgroup: use kzalloc() and list_del_init() | From | Tejun Heo <> |
| |
Hello,
On Wed, Jun 12, 2013 at 7:38 PM, Kent Overstreet <koverstreet@google.com> wrote: > IMO, list_del() is preferred when the object shouldn't be reused (i.e. > it gets taken off a list and then it's freed). list_del_init() could > hide bugs.
Nah... use-after-frees are detected much more reliably by poisoning anyway. Using list_del() instead of list_del_init() to hunt down use-after-free isn't a good idea because you're likely to corrupt the memory of unrelated area. I really don't see much point in using list_del().
Thanks.
-- tejun
| |