Messages in this thread | | | Subject | Re: [PATCH] checkpatch: forgive use of mixed case variables measuring units | From | Joe Perches <> | Date | Wed, 12 Jun 2013 09:26:01 -0700 |
| |
On Wed, 2013-06-12 at 12:17 -0400, Jason Cooper wrote: > On Wed, Jun 12, 2013 at 09:02:15AM -0700, Joe Perches wrote: > > On Wed, 2013-06-12 at 15:59 +0300, Phil Carmody wrote: > > > I agree that a creeping list of exceptions where CamelCase > > > is to be overlooked would be bad, but I would argue that > > > perhaps my exceptions aren't actual CamelCase - they're > > > (pretending to be) SI units, and just happen to match the > > > CamelCase regexp. I did a grep for my regexp, and everything > > > I noticed in a quick scan did look like a justifiable > > > variable name. > > > > Maybe, but this regex misses variants like: > > > > regulator_min_uA_show > > > > Maybe "^[a-z_]*_[numk][VAS](?:_\w+)?$" > > > > But this regex also does not match on other common > > sound variants "_dB", "_mB" and temperature like "_mC". > > And _dBm ...
As far as I can tell, all those uses are either in staging or are in obsolete/superceded code.
There is one I think ugly variant that could be fixed:
drivers/media/dvb-frontends/stv0367_priv.h: s32 Power_dBmx10; /* Power of the RF signal (dBm x 10) */
| |