Messages in this thread | | | Date | Wed, 12 Jun 2013 09:51:38 -0600 | From | Stephen Warren <> | Subject | Re: [PATCH v4] ARM: dts: OMAP5: Add palmas MFD node and regulator nodes |
| |
On 06/12/2013 02:19 AM, J Keerthy wrote: > This patch adds Palmas MFD node and the regulator nodes for OMAP5. > > The node definitions are based on: https://lkml.org/lkml/2013/6/6/25 > > Boot tested on omap5-uevm board.
Reviewed-by: Stephen Warren <swarren@nvidia.com>
> diff --git a/arch/arm/boot/dts/omap5-uevm.dts b/arch/arm/boot/dts/omap5-uevm.dts
> + palmas: palmas@48 { > + reg = <0x48>; > + interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>; /* IRQ_SYS_1N */ > + interrupt-parent = <&gic>; > + compatible = "ti,palmas";
... although personally I prefer the compatible property to be right at the top of each node, since it's what implies the schema for the rest of the node. That's a tiny nit though; feel free to ignore it if the OMAP files don't follow that convention.
| |