lkml.org 
[lkml]   [2013]   [Jun]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: tidspbridge: Fix potential NULL pointer dereference
Thank you Dan! That's right, It's of course not NULL after freed.
Yes the code looks strange here, I'm not sure what was intended.

Best regards,

Emil

On Wed, Jun 12, 2013 at 08:08:17AM -0700, Dan Carpenter wrote:
> 1) This patch doesn't do anything. "dcd_key" points to freed memory
> but it's not a NULL pointer.
> 2) The original pointer doesn't dereference "dcd_key" it just takes
> the address of one of the elements. I don't know the context and
> can't say for sure that it's a wrong thing to do.
>
> The code does look very suspect. Why is it checking permisions
> after we already removed the element and freed it?
>
> But it's not a dereferencing freed memory bug.
>
> regards,
> dan carpenter
>


\
 
 \ /
  Last update: 2013-06-12 17:41    [W:0.378 / U:0.312 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site