Messages in this thread | | | From | "Rafael J. Wysocki" <> | Subject | Re: [PATCH] PM / Sleep: Print last wakeup source on failed wakeup_count write | Date | Wed, 12 Jun 2013 13:08:30 +0200 |
| |
On Tuesday, June 11, 2013 04:17:35 PM Julius Werner wrote: > > This is going to be done in the autosleep case too, which I'm slightly > > concerned about. > > > > If you wanted to cover /sys/power/wakeup_count only, it would be better > > to put that into wakeup_count_store(), but perhaps you wanted to cover > > autosleep too? > > > > Hmm... no, I did not really take the autosleep case into account. I can't > quite tell with what frequency the autosleep try_to_suspend() handler on an > active system would run... do you think it might be a useful feature to > have there, or would it lead to logspam?
On Android systems it may be really frequent, because they try to suspend very aggressively. That's why I asked about it.
> I can move it to wakeup_count_store() if you prefer, but then I will have > to turn print_active_wakeup_sources() into an exported function, which is > also a little inconvenient.
That's OK.
Thanks, Rafael
-- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.
| |