lkml.org 
[lkml]   [2013]   [Jun]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 02/11] clocksource:global_timer: Add ARM global timer support.
    On 11/06/13 21:13, Linus Walleij wrote:
    > On Tue, Jun 11, 2013 at 4:05 PM, Srinivas KANDAGATLA
    > <srinivas.kandagatla@st.com> wrote:
    >
    >> Doing this is not adding any value to the driver, because
    >> 1. Currently the driver only support DT boot paths, in my previous RFC
    >> patches, Arnd suggested to get rid of the header as all platforms are DT
    >> now.
    >
    > In that case why do you have the separate global_timer_init()
    > at all? Just move that code into global_timer_of_register() and
    > also remove the #ifdef around CONFIG_OF and make the driver
    > depend on CONFIG_OF in Kconfig.
    >
    > After this you realize that all that business with
    > clk_register_clkdev() / clk_get_sys() is just pure surplus
    > baggade, you just use of_clk_get() and that's it.

    It makes sense to move all the code into global_timer_of_register().
    This will also get rid of un-used code. I will do this in the next spin.

    Thanks,
    srini

    >
    > Yours,
    > Linus Walleij
    > _______________________________________________
    > devicetree-discuss mailing list
    > devicetree-discuss@lists.ozlabs.org
    > https://lists.ozlabs.org/listinfo/devicetree-discuss
    >



    \
     
     \ /
      Last update: 2013-06-12 13:01    [W:2.865 / U:0.164 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site