Messages in this thread | | | Date | Wed, 12 Jun 2013 11:38:37 +0300 | Subject | Re: [PATCH v2 2/4] dma: move dw_dmac driver to an own directory | From | Andy Shevchenko <> |
| |
On Wed, Jun 12, 2013 at 10:52 AM, Vinod Koul <vinod.koul@intel.com> wrote: > On Wed, Jun 12, 2013 at 11:27:51AM +0300, Andy Shevchenko wrote: >> On Wed, Jun 12, 2013 at 10:39 AM, Vinod Koul <vinod.koul@intel.com> wrote: >> >> [] >> >> > Something like >> > config DW_DMAC_BIG_ENDIAN_IO >> > tristate >> > >> > config DW_DMAC >> > select DW_DMAC_BIG_ENDIAN_IO >> > >> > I belive DW_DMAC is for AVR support and the PCI ones is different right. >> > The point is that these things should be selected by the required symbols based >> > on what ARCH we are on and not be prompted for user to configure via menuconfig >> >> DW_DMAC is a generic platform driver which supports AVR32, ARM and >> Intel (ACPI case) platforms. >> >> We may do that option invisible to user > Yup >> >> and then use >> >> config DW_DMAC >> select DW_DMAC_BIG_ENDIAN_IO if ARCH=AVR32 > Thats would be the right way
Do you prefer to have this as separate patch or integrated in the split? In my humble opinion I better to do separate patch.
-- With Best Regards, Andy Shevchenko
| |