lkml.org 
[lkml]   [2013]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 2/4] mfd: dbx500-prcmu: Correctly reorder PRCMU clock identifiers
From
On Fri, Jun 7, 2013 at 4:20 PM, Lee Jones <lee.jones@linaro.org> wrote:
> On Fri, 07 Jun 2013, Linus Walleij wrote:
>
>> > -enum prcmu_clock {
>> > - PRCMU_SGACLK,
>> (...)
>> > +#define ARMCLK 0
>> > +#define PRCMU_ACLK 1
>> (...)
>>
>> It seems the enum and the defines want to do two different things?
>>
>> The first is a kernel-internal representation of the clocks, whereas
>> the latter is a HW-centric representation for a certain PRCMU
>> variant (I guess?)
>>
>> Does one actually exclude the other?
>
> From what I can tell, they're non-ordered values which are used as
> read-ins to the clk_mgt array. So long as they are unique I'm not sure
> the order matters. The current order seems 'made up', unless I'm
> mistaken.

Hm, I suspect it might be something to do with the enumeration
inside the PRCMU firmware, but I don't really know. In that case it
could affect the message marshalling, but let's call out the experts...

Yours,
Linus Walleij


\
 
 \ /
  Last update: 2013-06-10 14:01    [W:0.060 / U:0.708 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site