Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH v5 1/2] watchdog: New watchdog driver for MEN A21 watchdogs | Date | Sat, 01 Jun 2013 10:56:16 +0200 |
| |
On Friday 31 May 2013 10:58:48 Johannes Thumshirn wrote: > This patch adds the driver for the watchdog devices found on MEN Mikro > Elektronik A21 VMEbus CPU Carrier Boards. It has DT-support and uses the > watchdog framework. >
It seems the DT support is rather incomplete
> Signed-off-by: Johannes Thumshirn <johannes.thumshirn@men.de> > --- > MAINTAINERS | 6 ++ > drivers/watchdog/Kconfig | 8 ++ > drivers/watchdog/Makefile | 1 +
Please add a binding document to Documentation/devicetree/bindings/
> + > +#define GPIO_WD_ENAB 169 > +#define GPIO_WD_FAST 170 > +#define GPIO_WD_TRIG 171 > + > +#define GPIO_RST_CAUSE_BASE 166
You should never hardwire GPIO numbers like this. There is a DT binding for GPIO, so use that to get the number of the tree.
Arnd
| |