Messages in this thread | | | From | H Hartley Sweeten <> | Date | Thu, 9 May 2013 16:33:01 -0500 | Subject | RE: [PATCH 12/12] staging: COMEDI should depend on HAS_DMA |
| |
On Thursday, May 09, 2013 2:05 PM, Geert Uytterhoeven wrote: > If NO_DMA=y: > > ERROR: "dma_free_coherent" [drivers/staging/comedi/comedi.ko] undefined! > ERROR: "dma_alloc_coherent" [drivers/staging/comedi/comedi.ko] undefined! > > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> > Cc: Ian Abbott <abbotti@mev.co.uk> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: devel@driverdev.osuosl.org
Grr..
The error appears to be caused by the dma alloc/free in comedi_buf.c. These only happen if the (s->async_dma_dir != DMA_NONE). The comedi core defaults the async_dma_dir to DMA_NONE. The only comedi drivers that set it are ni_660x, ni_mio_common, and ni_pcidio.
The mite driver also has a dma_alloc/free.
Ian, can you think of a better solution than just making comedi depend on HAS_DMA?
Thanks, Hartley
| |