lkml.org 
[lkml]   [2013]   [May]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] perf: detect when perf.data file not closed out properly
On 5/9/13 3:32 AM, Ingo Molnar wrote:
>
> * David Ahern <dsahern@gmail.com> wrote:
>
>> + pr_err("data size is 0. "
>> + "Was the record command properly terminated?\n");
>
> Btw., a small stylistic request: please put user-visible strings into a
> single line - even if it technically turns into an overlong line.
>
> pr_err("data size is 0. Was the record command properly terminated?\n");
>
> This 1) makes it easier for people to git grep the error text they are
> seeing during usage 2) makes it easier for _developers_ to see the
> messages they are outputing to users.

Totally agree just battling the line length.

>
> For example from the single-line output it's immediately visible that it
> should be capitalized thusly:
>
> pr_err("Data size is 0. Was the record command properly terminated?\n");
>

Ok. Will re-send later today.

David


\
 
 \ /
  Last update: 2013-05-09 16:41    [W:0.089 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site