Messages in this thread | | | Date | Wed, 8 May 2013 15:16:22 -0700 | From | Andrew Morton <> | Subject | Re: [patch] err.h: IS_ERR() can accept __user pointers |
| |
On Wed, 8 May 2013 10:42:22 +0300 Dan Carpenter <dan.carpenter@oracle.com> wrote:
> Sparse generates a false positive when you pass a __user or __iomem > pointer to the IS_ERR() functions. > > drivers/rtc/rtc-ds1286.c:344:36: sparse: incorrect type in argument 1 (different address spaces) > drivers/rtc/rtc-ds1286.c:344:36: expected void const *ptr > drivers/rtc/rtc-ds1286.c:344:36: got unsigned int [noderef] [usertype] <asn:2>*rtcregs > > We can silence these by adding a __force here and upgrading to the > latest git release of Sparse. > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > --- > This change has no effect when using current Sparse releases.
You often put really important stuff after the ^--- and I always move it to before the ^--- :)
| |