lkml.org 
[lkml]   [2013]   [May]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] drm: refactor call to request_module
From
Date
Am Dienstag, den 07.05.2013, 12:32 -0700 schrieb Kees Cook:
> This reduces the size of the stack frame when calling request_module().
> Performing the sprintf before the call is not needed.

Good fine. Do you have any hard numbers for the record?

Did you find this just by reading the code or are there any problems
with stack sizes on some systems?

(This patch would be good alone for decreasing the number of code
lines. ;-))

> Signed-off-by: Kees Cook <keescook@chromium.org>
> ---
> drivers/gpu/drm/drm_encoder_slave.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)

Acked-by: Paul Menzel <paulepanter@users.sourceforge.net>


Thanks,

Paul
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2013-05-08 10:01    [W:0.040 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site