lkml.org 
[lkml]   [2013]   [May]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5, part4 20/41] mm/h8300: prepare for removing num_physpages and simplify mem_init()
Hello.

On 05/08/2013 08:26 PM, Sergei Shtylyov wrote:

>
>> Prepare for removing num_physpages and simplify mem_init().
>
>> Signed-off-by: Jiang Liu <jiang.liu@huawei.com>
>> Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
>> Cc: Geert Uytterhoeven <geert@linux-m68k.org>
>> Cc: linux-kernel@vger.kernel.org
>> ---
>> arch/h8300/mm/init.c | 34 ++++++++--------------------------
>> 1 file changed, 8 insertions(+), 26 deletions(-)
>
>> diff --git a/arch/h8300/mm/init.c b/arch/h8300/mm/init.c
>> index 22fd869..0088f3a 100644
>> --- a/arch/h8300/mm/init.c
>> +++ b/arch/h8300/mm/init.c
>> @@ -121,40 +121,22 @@ void __init paging_init(void)
>>
>> void __init mem_init(void)
>> {
>> - int codek = 0, datak = 0, initk = 0;
>> - /* DAVIDM look at setup memory map generically with reserved
>> area */
>> - unsigned long tmp;
>> - extern unsigned long _ramend, _ramstart;
>> - unsigned long len = &_ramend - &_ramstart;
>> - unsigned long start_mem = memory_start; /* DAVIDM - these must
>> start at end of kernel */
>> - unsigned long end_mem = memory_end; /* DAVIDM - this must not
>> include kernel stack at top */
>> + unsigned long codesize = _etext - _stext;
>>
>> #ifdef DEBUG
>> - printk(KERN_DEBUG "Mem_init: start=%lx, end=%lx\n", start_mem,
>> end_mem);
>> + pr_debug("Mem_init: start=%lx, end=%lx\n", memory_start,
>> memory_end);
>> #endif
>
> pr_debug() only prints something if DEBUG is #define'd, so you can
> drop the #ifdef here.

Although, not necessarily: it also supports CONFIG_DYNAMIC_DEBUG --
look at how pr_debug() is defined.
So this doesn't seem to be an equivalent change, and I suggest not doing
it at all.

WBR, Sergei



\
 
 \ /
  Last update: 2013-05-08 21:41    [W:0.177 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site