lkml.org 
[lkml]   [2013]   [May]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] mm: honor FOLL_GET flag in follow_hugetlb_page v2
From
On Tue, May 7, 2013 at 10:41 PM, KOSAKI Motohiro
<kosaki.motohiro@gmail.com> wrote:
> On Tue, May 7, 2013 at 8:51 PM, Jerome Glisse <j.glisse@gmail.com> wrote:
>> On Tue, May 7, 2013 at 8:47 PM, KOSAKI Motohiro
>> <kosaki.motohiro@gmail.com> wrote:
>>> On Tue, May 7, 2013 at 6:58 PM, <j.glisse@gmail.com> wrote:
>>>> From: Jerome Glisse <jglisse@redhat.com>
>>>>
>>>> Do not increase page count if FOLL_GET is not set. None of the
>>>> current user can trigger the issue because none of the current
>>>> user call __get_user_pages with both the pages array ptr non
>>>> NULL and the FOLL_GET flags non set in other word all caller
>>>> of __get_user_pages that don't set the FOLL_GET flags also call
>>>> with pages == NULL.
>>>
>>> Because, __get_user_pages() doesn't allow pages==NULL and FOLL_GET is on.
>>
>> Yes but this allow pages != NULL and FOLL_GET not set and as i said
>> there is no such user of that yet and this is exactly what i was
>> trying to use.
>
> Why? The following bug_on inhibit both case.

Yes i get lost on the double negation, but still my patch is correct
and i am not using gup but follow_hugetlb_page directly and i run into
the issue. My patch does not change the behavior for current user,
just fix assumption new user might have when not setting the FOLL_GET
flags.

>>> VM_BUG_ON(!!pages != !!(gup_flags & FOLL_GET));


\
 
 \ /
  Last update: 2013-05-08 17:21    [W:0.042 / U:0.444 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site