lkml.org 
[lkml]   [2013]   [May]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Suggestion] kernel/cgroup.c: about kfree after 'get_new_cssid'
On 2013年05月08日 08:50, Li Zefan wrote:
>>> There's a bug in cgroup_unload_subsys() that idr_destroy() should be called after
>>> >> ss->css_free(). That said, given there's no modular cgroup subsystem using css_id,
>>> >> and the whole css_id thing will be eliminated in 3.11, why bother fixing it.
>>> >>
>> >
>> > I just find it by reading code (I also want to learn about kernel).
>> >
>> > I guess, for some stable versions, may focus on it, they are the
>> > different branches from the latest version.
>> >
>> > So, is it suitable to send related patch for the bug ?
>> >
> As I said, there's no modular cgroup subsystem using css_id, so the bug
> doesn't exist in real world.
>
>
>

Excuse me, my English is not quite well, I guess what you said is:

a. idr_destroy() should be called after ss->css_free()
b. need check the return value of cgroup_init_idr() in cgroup_init().

but all features which related with the 2 issues above, never be used
in any main linux main branches.
so, the 2 bugs doesn't exist in real world.

Is what I guess correct ?

Thanks.

--
Chen Gang

Asianux Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2013-05-08 04:41    [W:0.075 / U:0.168 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site