Messages in this thread | | | Date | Tue, 7 May 2013 16:28:38 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH] rtc: rtc-tile: add missing platform_device_unregister() when module exit |
| |
On Sun, 5 May 2013 13:07:00 +0800 Wei Yongjun <weiyj.lk@gmail.com> wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn> > > We have registered platform device when module init, and > need unregister it when module exit. > > ... > > --- a/drivers/rtc/rtc-tile.c > +++ b/drivers/rtc/rtc-tile.c > @@ -146,6 +146,7 @@ exit_driver_unregister: > */ > static void __exit tile_rtc_driver_exit(void) > { > + platform_device_unregister(tile_rtc_platform_device); > platform_driver_unregister(&tile_rtc_platform_driver); > }
We don't need to do a platform_device_put(), as tile_rtc_driver_init() does?
drivers/rtc/rtc-stmp3xxx.c appears to need the same fix.
| |