Messages in this thread | | | Date | Tue, 7 May 2013 10:16:57 -0400 | From | Vivek Goyal <> | Subject | Re: [PATCHSET v2] blk-throttle: implement proper hierarchy support |
| |
On Mon, May 06, 2013 at 03:45:39PM -0700, Tejun Heo wrote: > Changes since the last take[L] are > > * Unnecessary throtl_schedule_delayed_work() call dropped from 0007. > > * throtl_log() implement in 0021 forgot to print space after blkg > path. Fixed. > > * 0030-blk-throttle-add-throtl_qnode-for-dispatch-fairness.patch added > to address dispatch fairness. > > * 0031-blk-throttle-Account-for-child-group-s-start-time-in.patch > added to address unwarranted penalty of nested limit enforcement due > to staggered delays of slice start times at multiple levels. > > The original patchset description follows.
Hi Tejun,
Can you please also update blkio-controller.txt file to reflect the fact that now throttling also supports hierarchy. One of the places which needs updation is following.
Hierarchical Cgroups ==================== - Currently only CFQ supports hierarchical groups. For throttling, cgroup interface does allow creation of hierarchical cgroups and internally it treats them as flat hierarchy.
Thanks Vivek
| |