lkml.org 
[lkml]   [2013]   [May]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] PCI: move down pci_fixup_final for hotplug path
From
On Tue, May 7, 2013 at 2:38 PM, Bjorn Helgaas <bhelgaas@google.com> wrote:
> On Tue, May 7, 2013 at 2:32 PM, Bjorn Helgaas <bhelgaas@google.com> wrote:
>>
>> PCI: Delay final fixups until resources are assigned
>>
>> Commit 4f535093cf "PCI: Put pci_dev in device tree as early as possible"
>> moved final fixups from pci_bus_add_device() to pci_device_add(). But
>> pci_device_add() happens before resource assignment, so BARs may not be
>> valid yet.
>>
>> Typical flow for hot-add:
>>
>> pciehp_configure_device
>> pci_scan_slot
>> pci_scan_single_device
>> pci_device_add
>> pci_fixup_device(pci_fixup_final, dev) # previous location
>> # resource assignment happens here
>> pci_bus_add_devices
>> pci_bus_add_device
>> pci_fixup_device(pci_fixup_final, dev) # new location
>>
>> [bhelgaas: changelog, move fixups to pci_bus_add_device()]

Yes, that is right fix.

Thanks

Yinghai


\
 
 \ /
  Last update: 2013-05-08 00:41    [W:0.383 / U:0.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site