Messages in this thread | | | Date | Tue, 7 May 2013 14:08:57 -0700 | From | Sören Brinkmann <> | Subject | Re: [PATCH] clk: Always notify whole subtree when reparenting |
| |
On Tue, May 07, 2013 at 01:59:53PM -0700, Mike Turquette wrote: > Quoting Soren Brinkmann (2013-04-16 10:06:50) > > A clock's notifier count only reflects notifiers which are registered > > directly for that clock. A reparent operation though affects the whole > > subtree because of a potential rate change. > > When issuing the pre rate change notifications only the notifier count > > for the clock to be changed is considered and notifiers for subclocks > > may never be called. Resulting in clocks in the subtree which have > > registered notifiers, may receive a POST_- or ABORT_RATE_CHANGE > > notification, without a PRE_RATE_CHANGE_NOTIFICATION. > > Therefore always traverse the whole subtree when issueing pre rate > > change notifications during a reparent operation. > > > > Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com> > > --- > > This should probably be considered an RFC. There may be smarter ways to > > resolve this issue. E.g. forward notifier counts upstream the way it is done > > with enable counts. > > > > I've taken this patch for 3.11. thank you.
Sören
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |