lkml.org 
[lkml]   [2013]   [May]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 046/118] bonding: fix bonding_masters race condition in bond unloading
    Date
    3.5.7.12 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: "nikolay@redhat.com" <nikolay@redhat.com>

    commit 69b0216ac255f523556fa3d4ff030d857eaaa37f upstream.

    While the bonding module is unloading, it is considered that after
    rtnl_link_unregister all bond devices are destroyed but since no
    synchronization mechanism exists, a new bond device can be created
    via bonding_masters before unregister_pernet_subsys which would
    lead to multiple problems (e.g. NULL pointer dereference, wrong RIP,
    list corruption).

    This patch fixes the issue by removing any bond devices left in the
    netns after bonding_masters is removed from sysfs.

    Signed-off-by: Nikolay Aleksandrov <nikolay@redhat.com>
    Acked-by: Veaceslav Falico <vfalico@redhat.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
    ---
    drivers/net/bonding/bond_main.c | 9 +++++++++
    1 file changed, 9 insertions(+)

    diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
    index 1a6b118..5fc31a1 100644
    --- a/drivers/net/bonding/bond_main.c
    +++ b/drivers/net/bonding/bond_main.c
    @@ -4870,9 +4870,18 @@ static int __net_init bond_net_init(struct net *net)
    static void __net_exit bond_net_exit(struct net *net)
    {
    struct bond_net *bn = net_generic(net, bond_net_id);
    + struct bonding *bond, *tmp_bond;
    + LIST_HEAD(list);

    bond_destroy_sysfs(bn);
    bond_destroy_proc_dir(bn);
    +
    + /* Kill off any bonds created after unregistering bond rtnl ops */
    + rtnl_lock();
    + list_for_each_entry_safe(bond, tmp_bond, &bn->dev_list, bond_list)
    + unregister_netdevice_queue(bond->dev, &list);
    + unregister_netdevice_many(&list);
    + rtnl_unlock();
    }

    static struct pernet_operations bond_net_ops = {
    --
    1.8.1.2


    \
     
     \ /
      Last update: 2013-05-07 17:21    [W:4.059 / U:0.152 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site