lkml.org 
[lkml]   [2013]   [May]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 105/118] mwifiex: Call pci_release_region after calling pci_disable_device
    Date
    3.5.7.12 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Yogesh Ashok Powar <yogeshp@marvell.com>

    commit 5b0d9b218b74042ff72bf4bfda6eeb2e4bf98397 upstream.

    "drivers should call pci_release_region() AFTER
    calling pci_disable_device()"

    Please refer section 3.2 Request MMIO/IOP resources
    in Documentation/PCI/pci.txt

    Signed-off-by: Avinash Patil <patila@marvell.com>
    Signed-off-by: Amitkumar Karwar <akarwar@marvell.com>
    Signed-off-by: Yogesh Ashok Powar <yogeshp@marvell.com>
    Signed-off-by: Bing Zhao <bzhao@marvell.com>
    Signed-off-by: John W. Linville <linville@tuxdriver.com>
    Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
    ---
    drivers/net/wireless/mwifiex/pcie.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/wireless/mwifiex/pcie.c b/drivers/net/wireless/mwifiex/pcie.c
    index ce2c101..b7a5387 100644
    --- a/drivers/net/wireless/mwifiex/pcie.c
    +++ b/drivers/net/wireless/mwifiex/pcie.c
    @@ -1831,9 +1831,9 @@ static void mwifiex_pcie_cleanup(struct mwifiex_adapter *adapter)
    if (pdev) {
    pci_iounmap(pdev, card->pci_mmap);
    pci_iounmap(pdev, card->pci_mmap1);
    + pci_disable_device(pdev);
    pci_release_region(pdev, 2);
    pci_release_region(pdev, 0);
    - pci_disable_device(pdev);
    pci_set_drvdata(pdev, NULL);
    }
    }
    --
    1.8.1.2


    \
     
     \ /
      Last update: 2013-05-07 16:44    [W:4.099 / U:0.156 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site