Messages in this thread | | | Date | Tue, 7 May 2013 15:21:59 +0200 | From | "Yann E. MORIN" <> | Subject | Re: [PATCH] menuconfig: fix NULL pointer dereference when searching a symbol |
| |
Li, All,
On Tue, May 07, 2013 at 10:40:59AM +0800, Li Zefan wrote: > Searching PPC_EFIKA results segmentation fault, and it's because > get_symbol_prop() returns NULL. > > In this case CONFIG_PPC_EFIKA is defined in arch/powerpc/platforms/ > 52xx/Kconfig, so it won't be parsed if ARCH!=PPC, but menuconfig > knows this symbol when it parses sound/soc/fsl/Kconfig: > > config SND_MPC52xx_SOC_EFIKA > tristate "SoC AC97 Audio support for bbplan Efika and STAC9766" > depends on PPC_EFIKA > > This bug was introduced by commit bcdedcc1afd6 ("menuconfig: print more > info for symbol without prompts"). > > Reported-by: Borislav Petkov <bp@alien8.de> > Signed-off-by: Li Zefan <lizefan@huawei.com>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Michal, I'll get this in my tree, and will send a pull-request to you later (I may have a few other smallish fixes shortly).
Regards, Yann E. MORIN.
-- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
| |