Messages in this thread | | | Date | Tue, 7 May 2013 09:16:03 +0100 | From | Lee Jones <> | Subject | Re: [PATCH 5/7] gpio: tc3589x: remove unnecessary platform_set_drvdata() |
| |
On Mon, 06 May 2013, Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release > or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d > (device-core: Ensure drvdata = NULL when no driver is bound). > Thus, it is not needed to manually clear the device driver data to NULL. > > Signed-off-by: Jingoo Han <jg1.han@samsung.com> > --- > drivers/gpio/gpio-tc3589x.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/drivers/gpio/gpio-tc3589x.c b/drivers/gpio/gpio-tc3589x.c > index d34d80d..4a5de27 100644 > --- a/drivers/gpio/gpio-tc3589x.c > +++ b/drivers/gpio/gpio-tc3589x.c > @@ -407,7 +407,6 @@ static int tc3589x_gpio_remove(struct platform_device *pdev) > > free_irq(irq, tc3589x_gpio); > > - platform_set_drvdata(pdev, NULL); > kfree(tc3589x_gpio); > > return 0;
Acked-by: Lee Jones <lee.jones@linaro.org>
-- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |