lkml.org 
[lkml]   [2013]   [May]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5 6/7] sched: consider runnable load average in move_tasks
On 05/06/2013 04:53 PM, Paul Turner wrote:
>> > +static unsigned long task_h_load_avg(struct task_struct *p)
>> > +{
>> > + return div_u64(task_h_load(p) * (u64)p->se.avg.runnable_avg_sum,
>> > + p->se.avg.runnable_avg_period + 1);
> Similarly, I think you also want to at least include blocked_load_avg here.
>
> More fundamentally:
> I suspect the instability from comparing these to an average taken on
> them will not give a representative imbalance weight. While we should
> be no worse off than the present situation; we could be doing much
> better.
>
> Consider that by not consuming {runnable, blocked}_load_avg directly
> you are "hiding" the movement from one load-balancer to the next.

Sure, sounds reasonable, I will try it.

--
Thanks
Alex


\
 
 \ /
  Last update: 2013-05-06 17:43    [W:0.296 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site