lkml.org 
[lkml]   [2013]   [May]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 3/3] usb: misc: usb3503: Remove 100ms sleep on reset, conform to data sheet
From
Signed-off-by: Dongjin Kim <tobetter@gmail.com>

On Sat, Jun 1, 2013 at 10:34 AM, Julius Werner <jwerner@chromium.org> wrote:
> The usb3503 driver sleeps a flat 100ms when resetting the chip, with a
> comment about waiting for the reference clock. This seems to be a
> board-specific detail that should not hold up boot across all platforms.
> This patch reduces the sleep to the 4ms initialization delay that the
> chip itself actually requires (as per its data sheet). If certain boards
> require more time to set up the reference clock, they should change this
> through local patches or add a proper, configurable synchronization
> mechanism.
>
> Signed-off-by: Julius Werner <jwerner@chromium.org>
> ---
> drivers/usb/misc/usb3503.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/usb/misc/usb3503.c b/drivers/usb/misc/usb3503.c
> index a647a2e..a1d509f 100644
> --- a/drivers/usb/misc/usb3503.c
> +++ b/drivers/usb/misc/usb3503.c
> @@ -107,11 +107,9 @@ static int usb3503_reset(int gpio_reset, int state)
> if (gpio_is_valid(gpio_reset))
> gpio_set_value(gpio_reset, state);
>
> - /* Wait RefClk when RESET_N is released, otherwise Hub will
> - * not transition to Hub Communication Stage.
> - */
> + /* Wait T_HUBINIT == 4ms for hub logic to stabilize */
> if (state)
> - msleep(100);
> + usleep_range(4000, 10000);
>
> return 0;
> }
> --
> 1.7.12.4
>


\
 
 \ /
  Last update: 2013-06-01 06:41    [W:0.066 / U:0.996 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site