Messages in this thread | | | Date | Fri, 31 May 2013 08:41:48 -0500 | From | Timur Tabi <> | Subject | Re: [PATCH v3 7/8] video: xilinxfb: Fix sparse warnings |
| |
On 05/31/2013 08:37 AM, Michal Simek wrote: > The same is for Microblaze. Driver shares fb_virt for IO memory > and for allocated memory. The purpose of this driver wasn't > to change the driver logic just resolved sparse warnings. > The other way is also wrong. > I have compiled this driver with ppc toolchain and it should > remove sparse warnings for PPC.
But it's not I/O memory. It's regular memory. __iomem is for memory-mapped I/O, which is limited to a specific range of memory locations.
If sometimes you use regular memory for the framebuffer, and other times you use real I/O memory for the framebuffer, then you should have two different pointers.
-- Timur Tabi
| |