Messages in this thread | | | Date | Fri, 31 May 2013 11:12:27 +0200 | Subject | Re: [PATCH v2] arch: m68k: math-emu: unsigned issue, 'unsigned long' will never be less than zero | From | Geert Uytterhoeven <> |
| |
On Thu, May 30, 2013 at 10:21 AM, Chen Gang <gang.chen@asianux.com> wrote: > 'oldmant.m32[1]' is 'unsigned long' which never '< 0', and the original > author wanted to check the highest bit whether set. > > So need make the bit test explicit (which is better than type cast form > 'unsigned long' to 'long'). > > The related warning: (with EXTRA_CFLAGS=-W ARCH=m68k for allmodconfig) > arch/m68k/math-emu/fp_arith.c:522:4: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits] > > Signed-off-by: Chen Gang <gang.chen@asianux.com>
Thanks, applied and queued for 3.11!
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |