lkml.org 
[lkml]   [2013]   [May]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] timer: Fix jiffies wrap behavior of round_jiffies*()
On 05/30/13 01:01, Andrew Morton wrote:
> On Tue, 21 May 2013 20:43:50 +0200 Bart Van Assche <bart.vanassche@gmail.com> wrote:
>
>> Make sure that the round_jiffies*() functions return a time that is
>> in the future when the jiffies counter is about to wrap.
>
> Actually "when the jiffies counter has recently wrapped".
>
> I assume this was found by inspection?

Hello Andrew,

You are correct, this was found via source code inspection. I started
reviewing the round_jiffies*() implementation because I was chasing a
bug in a kernel driver using one of these functions.

>> - return original;
>> - return j;
>> + return time_is_after_jiffies(j) ? j : original;
>> }
>
> Your email client mangles patches, btw.

Sorry. Will take more care in the future.

Bart.



\
 
 \ /
  Last update: 2013-05-30 08:41    [W:0.067 / U:0.184 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site