Messages in this thread | | | From | Jingoo Han <> | Subject | Re: [PATCH 04/42] rtc: rtc-ab8500: remove unnecessary platform_set_drvdata() | Date | Fri, 03 May 2013 16:35:52 +0900 |
| |
On Friday, May 03, 2013 3:58 PM, Srinidhi Kasagar wrote: > On Fri, May 03, 2013 at 08:24:24 +0200, Jingoo Han wrote: > > The driver core clears the driver data to NULL after device_release > > or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d > > (device-core: Ensure drvdata = NULL when no driver is bound). > > Thus, it is not needed to manually clear the device driver data to NULL. > > > > Signed-off-by: Jingoo Han <jg1.han@samsung.com> > > --- > > drivers/rtc/rtc-ab8500.c | 2 -- > > 1 files changed, 0 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/rtc/rtc-ab8500.c b/drivers/rtc/rtc-ab8500.c > > index 63cfa31..c5b62d4 100644 > > --- a/drivers/rtc/rtc-ab8500.c > > +++ b/drivers/rtc/rtc-ab8500.c > > @@ -451,8 +451,6 @@ static int ab8500_rtc_remove(struct platform_device *pdev) > > { > > ab8500_sysfs_rtc_unregister(&pdev->dev); > > > > - platform_set_drvdata(pdev, NULL); > > - > > return 0; > > } > Ok, thanks. Hope you have taken care for the ab3100 too... > > Acked-by:srinidhi kasagar <srinidhi.kasagar@stericsson.com>
Hi Srinidhi Kasagar,
I have already modified the ab3100 RTC driver as below: (http://www.mail-archive.com/linux-kernel@vger.kernel.org/msg428126.html)
Thank you for your Acked-by. :)
Best regards, Jingoo Han
> > regards/srinidhi
| |