Messages in this thread | | | From | "Rafael J. Wysocki" <> | Subject | Re: [PATCH v2 00/10] optimize freezing tasks by reducing task wakeups | Date | Fri, 03 May 2013 13:43:46 +0200 |
| |
On Thursday, May 02, 2013 05:10:26 PM Tejun Heo wrote: > Hey, Rafael. > > On Thu, May 02, 2013 at 11:06:35PM +0200, Rafael J. Wysocki wrote: > > > v2 moves the skip check to freeze_task(), and expands the commit > > > messages. > > > > The entire series makes sense to me, so are there any objections? > > > > Tejun, Oleg?? > > Generally looks good to me. I'm a bit uncomfortable with the > generic-looking expansion of the freezable API as it can't be > something which can be used in any generic manner. It'd be great if > we just add only the used ones (do we already?)
I'm not sure about that, unfortunately.
> and add some sort of lockdep annotation so that people don't use them while > holding any locks.
I guess we can add that anyway?
Rafael
-- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.
| |