lkml.org 
[lkml]   [2013]   [May]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5/7] posix-cpu-timers: check_thread_timers() uses task_sched_runtime()
    Date
    From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>

    A type of tsk->se.sum_exec_runtime is u64. Thus, reading it is racy when
    running 32bit. We should use task_sched_runtime().

    Cc: Olivier Langlois <olivier@trillion01.com>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: Frederic Weisbecker <fweisbec@gmail.com>
    Cc: Ingo Molnar <mingo@kernel.org>
    Acked-by: Peter Zijlstra <peterz@infradead.org>
    Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
    ---
    kernel/posix-cpu-timers.c | 3 ++-
    1 files changed, 2 insertions(+), 1 deletions(-)

    diff --git a/kernel/posix-cpu-timers.c b/kernel/posix-cpu-timers.c
    index c69b8d8..4043282 100644
    --- a/kernel/posix-cpu-timers.c
    +++ b/kernel/posix-cpu-timers.c
    @@ -958,7 +958,8 @@ static void check_thread_timers(struct task_struct *tsk,
    struct cpu_timer_list *t = list_first_entry(timers,
    struct cpu_timer_list,
    entry);
    - if (!--maxfire || tsk->se.sum_exec_runtime < t->expires.sched) {
    + unsigned long long runtime = task_sched_runtime(tsk, false);
    + if (!--maxfire || runtime < t->expires.sched) {
    tsk->cputime_expires.sched_exp = t->expires.sched;
    break;
    }
    --
    1.7.1


    \
     
     \ /
      Last update: 2013-05-03 07:41    [W:2.961 / U:0.240 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site