Messages in this thread | | | Date | Fri, 03 May 2013 10:33:13 +0200 | From | Dirk Eibach <> | Subject | Re: [PATCH] powerpc: Make Book E watchdog reset type configurable |
| |
Hi Guenter,
>>>> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig >>>> index e89fc31..6048593 100644 >>>> --- a/drivers/watchdog/Kconfig >>>> +++ b/drivers/watchdog/Kconfig >>>> @@ -1172,6 +1172,38 @@ config BOOKE_WDT_DEFAULT_TIMEOUT >>>> >>>> The value can be overridden by the wdt_period command-line >>>> parameter. >>>> >>>> +choice >>>> + prompt "PowerPC Book-E Watchdog reset type" >>>> + depends on BOOKE_WDT >>>> + default BOOKE_WDT_RESET_CHIP >>>> + help >>>> + Specify what kind of reset will be executed on watchdog >>>> timeout. >>>> + >>> Seems to me it would be much better to make this configurable via >>> platform data >>> and/or device tree. >> >> good catch. What do the device-tree gurus think to be a nice >> property name?
having a closer look, I realized booke_wdt is not device-tree based yet. Migrating it would come close to a rewrite, breaking compatibility for all current users. Sorry, this is way beyond the time I have for this project. So I suggest merging the change the way it is, as it is clearly an improvement.
Cheers Dirk
| |