Messages in this thread | | | Date | Wed, 29 May 2013 16:01:49 -0700 | From | Zach Brown <> | Subject | Re: [RFC PATCH] vfs: add permute operation |
| |
> >> +static void sort_parents3(struct dentry **p) > >> +void sort_parents(struct dentry **p, unsigned *nump) > > > > Yikes, that's a bunch of fiddly code. Is it *really* worth all that to > > avoid calling the generic sort helpers? > > AFAICS, I cannot make the compare function transitive, e.g.: A is > descendant of C but B is unrelated. Then what should cmp(A, B) and > cmp(B, C) return?
Ah, of course. I wasn't reading closely enough.
- z
| |