lkml.org 
[lkml]   [2013]   [May]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ata: increase retry count but shorten duration for Calxeda controller
On 05/29/2013 03:12 PM, Timur Tabi wrote:
> On Wed, May 29, 2013 at 10:51 AM, Mark Langsdorf
> <mark.langsdorf@calxeda.com> wrote:
>>
>> {
>> - const unsigned long *timing = sata_ehc_deb_timing(&link->eh_context);
>> + unsigned long timing[] = { 5, 100, 500};
>
>
> You didn't address my comments the last time you posted this. I'll
> post them again:
>
>
> Why are you dropping the 'const'?
>
> Assuming it works, this should be more efficient:
>
> static const unsigned long timing[] = {5, 100, 500};

I thought there was a compile issue, but I just rechecked and there
wasn't. I'll fix for the next submission.

Thanks for the review.

--Mark Langsdorf



\
 
 \ /
  Last update: 2013-05-29 23:01    [W:0.094 / U:0.316 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site